remove xprofile visibility controls animation

[DJPaul]

The xprofile "change" visibility controls, whether front-end or in wp-admin, use a fairly common jQuery fade/slide animation. This feels pretty Web 2.0 and dated to me; removing the animation makes the UI feel more responsive IMO.

Current:

Proposed:

If we want to do this, I'm happy to work on the change.

[hnla]

Gee thanks Paul I added those fades amongst other things, nice to feel dated! :( #4224

Personally think they look fine, but change by all means it's just a matter of removing the slidedown & fadeup properties in js. If you want to get funky explore using CSS 'Transitions' for cool alternative effects; nice gifs though :)

[boonebgorges]

This seems fine to me, but how does it interface with #5352? Are these inline settings being removed?

[DJPaul]

Replying to boonebgorges:

This seems fine to me, but how does it interface with #5352? Are these inline settings being removed?

That's a good question we ought to have in that other thread; I don't know what plans John has for it.

[djpaul]

In 8021:

xProfile: change the field visibility JS to show/hide the controls immediately, rather than with a slide/fade transition.

This helps improve the perceived performance of the visibility
controls. The code quality of these parts of the JS has also been
improved.

Fixes #5439