Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5437 closed enhancement (fixed)

Add labels to BP Group Settings radio buttons

Reported by: tw2113's profile tw2113 Owned by: boonebgorges's profile boonebgorges
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Groups Keywords:
Cc:

Description

Instead of making users click the radio buttons directly, allow clicking the associated text as well. Also helps with accessibility

Attachments (2)

group-settings-label-patch.patch (3.1 KB) - added by tw2113 10 years ago.
group-settings-label-patch-1.patch (3.4 KB) - added by tw2113 10 years ago.
Adds fieldset and legeng to already supplied label fix.

Download all attachments as: .zip

Change History (7)

#1 @boonebgorges
10 years ago

  • Milestone changed from Awaiting Review to 2.0

Awesome, this looks like a good fix.

Your patch also demonstrates that our use of <label for="group-status"> is incorrect. Labels go with individual controls, not entire sets. We should wrap these options in a <fieldset> and then apply a <legend> instead of a top-level label. tw2113, you fancy updating your patch with that change?

#2 @tw2113
10 years ago

Sure, I can give that a go this weekend. I want to make sure the markup is applied correctly. It's been a little while since I used <legend> afterall.

@tw2113
10 years ago

Adds fieldset and legeng to already supplied label fix.

#3 @tw2113
10 years ago

I got ambitious :D

#4 @boonebgorges
10 years ago

Looks great, thanks!

#5 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 8013:

Reconfigure markup for radio buttons on group admin meta boxes

<label> elements should be applied to the individual radio buttons rather
than the entire set, for better accessibility and standards compliance.

The old top-level label is replaced by a fieldset and legend.

Fixes #5437

Props tw2113

Note: See TracTickets for help on using tickets.