Skip to:
Content

BuddyPress.org

Changes between Version 1 and Version 2 of Ticket #5436, comment 10


Ignore:
Timestamp:
06/02/2014 07:18:59 PM (11 years ago)
Author:
r-a-y
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5436, comment 10

    v1 v2  
    11I like the general idea behind the `'bp_setup_canonical_stack'` hook, however I dislike the name for it because it's a little too specific.  Other things could be used on this hook.
    22
    3 For example, the `xprofile_override_user_fullnames()` function in `04.patch` could potentially be hooked to ``bp_setup_canonical_stack'` within the `BP_XProfile_Component` class as a method, but the hook name doesn't make much sense.
     3For example, the `xprofile_override_user_fullnames()` function in `04.patch` could potentially be hooked to `'bp_setup_canonical_stack'` within the `BP_XProfile_Component` class as a method, but the hook name doesn't make much sense.
    44
    55Perhaps rename `bp_setup_canonical_stack` to `bp_setup_late_globals`?