Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 3 years ago

#5422 closed enhancement (maybelater)

Group invitations are only visible to the inviter

Reported by: dcavins Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Core Keywords: 2nd-opinion, trac-tidy-2018
Cc:

Description

The current bp_group_has_invites() loop only returns invitations for which the current user is the inviter to display on the "send invites" page of a group. (This is true even for site and group admins.)

This causes mysterious interactions for users. For instance, if a user tries to invite someone who's already been invited by someone else, the process seems to fail (without explanation). And if he contacts the group admin, the admin doesn't really know who's invited either.

My own opinion is that if you have permission to invite others to a group, you should be able to see who's already been invited just for simplicity's sake. Perhaps only site admins, group admins and the original inviter can modify the invitation (confirming or "sending" it and removing it), though.

Thanks for your thoughts.

Change History (7)

#1 @dcavins
7 years ago

  • Type changed from defect (bug) to enhancement

#2 @boonebgorges
7 years ago

  • Keywords 2nd-opinion added

I feel a bit uneasy about this for some vague privacy reasons, but when I try to put it into words, I can't figure out why. So I guess I don't have any real argument against it, and I definitely agree that it would ease user confusion.

I'd like to have another dev opinion before moving forward on this.

#3 @DJPaul
7 years ago

  • Milestone changed from Awaiting Review to Future Release

I don't think regular users should be able to see who has pending invites to a group; I think that crosses the privacy line. The idea makes me feel funny.

I can see benefit in the group admin and group moderators being able to see a list of pending invitations to the group, along with a timestamp and who invited them, and allowing them to re-send the invitation, just like what we've done with site signups in 2.0.

if a user tries to invite someone who's already been invited by someone else, the process seems to fail (without explanation)

This sounds like a relatively straightforward fix; we can add a more informative message. This should be reported as a separate ticket so we can milestone it accordingly.

#4 @dcavins
7 years ago

Hi DJPaul-

Great, so we're going to address these points:

  • Group/site admins can manage invitations from the front-end group interface
  • Users get better error messaging when attempting to invite already-invited users

Do you want to bust these into two new tickets and close this one? I can create first patches for both of these issues; let me know how you'd like to proceed. (Can we set the milestone on this to 2.1?)

Also, I'd like to point out that the new admin functionality is only possible thanks to the work boonebgorges did on this in r8045 for BP 2.0. I'm very motivated to make the group invitations system a little easier to use now that the groundwork's in place.

#5 @DJPaul
5 years ago

  • Component changed from General - UX/UI to Core

#6 @DJPaul
3 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#7 @DJPaul
3 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.