Avatar upload error mesage

[stefwilliams]

When an avatar image is uploaded to a profile or BP group, if the filename is too long (I think), the crop fails, with a generic message: "There was a problem cropping the avatar".
The image is still uploaded but the crop fails, saying the image is not found.
A more helpful error message would be good.
(As an example, the attached image fails as an avatar upload. Rename it to something shorter, and it should work.)

[stefwilliams]

failed avatar upload

[boonebgorges]

Thanks for the report. Actually, in your case, the file length is not the problem. The problem is the fact that you're uploading a file whose file is formatted like a BP avatar image file. When processing the crop, BuddyPress deletes all existing avatars before cropping and re-saving the new avatar. But because your new filename looked like an old avatar from BP's point of view, it was getting deleted too; as a result, there was nothing to crop, and BP threw an error.

It's an edge case to be sure, but we can work around it by ensuring that the existing file is not named the same as the uploaded file before deleting the existing one.

[boonebgorges]

In 7943:

Sanity check before deleting old avatar files before cropping new ones

Previously, if a user uploaded a new avatar file that had a name format like
an existing BP avatar file, BP would accidentally wipe that file out before
cropping. This would result in a failed crop, because the just-uploaded image
would be gone. This changeset introduces a sanity check: only delete existing
avatar files if the filename for those files is not the same as the uploaded
file.

Fixes #5417