Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #5411, comment 20


Ignore:
Timestamp:
03/07/2014 05:58:58 PM (12 years ago)
Author:
boonebgorges
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #5411, comment 20

    initial v1  
    11Hi r-a-y - That patch seems fine. In my mind, I guess I'd been thinking something more along the lines of:
    22
    3 `if ( empty( $group->admins ) ) {
     3{{{
     4if ( empty( $group->admins ) ) {
    45    $group = groups_get_group( array(
    56        'group_id' => $group->id,
    67        'populate_extras' => true,
    78    ) );
    8 }`
     9}
     10}}}
    911
    1012This prevents us from having to examine arguments for original intent, and also keeps all the query logic centralized in the BP_Groups_Group class. But it's a fairly small difference from what you're doing (and anyway, it should rarely be triggered) so whatever you think is best is OK with me.