Changes between Initial Version and Version 1 of Ticket #5411, comment 15
- Timestamp:
- 03/06/2014 08:41:55 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #5411, comment 15
initial v1 3 3 We can definitely do that. 4 4 5 However, the issue with BP Group Hierarchy is it already uses [https://github.com/ddean4040/BP-Group-Hierarchy/blob/master/bp-group-hierarchy-classes.php#L26 two arguments] in its constructor class. However, `BP_Groups_Group` just added a second parameter (r7898), so that causes some issues that could only be solved if ddean added a third parameter to his constructor or just ignores the `populate_extras` parameter and pastes all the extra group data calls into his `BP_Groups_Hierarchy::populate()` method.5 However, the issue with BP Group Hierarchy is it already uses [https://github.com/ddean4040/BP-Group-Hierarchy/blob/master/bp-group-hierarchy-classes.php#L26 two arguments] in its constructor class. However, `BP_Groups_Group` just added a second parameter (r7898), so that causes some issues that could only be solved if ddean added a third parameter to his constructor ~~or just ignores the `populate_extras` parameter and pastes all the extra group data calls into his `BP_Groups_Hierarchy::populate()` method~~. (I don't like the latter option I recommended!) 6 6 7 7 There might be other ways to solve the issue, but that's what I gathered from my quick audit of BP Group Hierarchy.