Bug in the notifications

[elpix]

Hi there,

There is a bug in the notifications, here is a screen : ​http://hpics.li/8d400ac

You see an empty white box below "Notifications".

Do not hesitate to contact me for more information.

Bye

[elpix]

Print screen

[boonebgorges]

It looks like this is an issue related to your use of the Buddybar, which we're no longer supporting. You are urged to migrate to the WordPress Admin Bar.

define( 'BP_USE_WP_ADMIN_BAR', true );

[elpix]

So we can't use the bp bar anymore ?
The WP bar is cheap compared to the buddybar :(

[boonebgorges]

You can use the Buddybar, but we're no longer supporting it officially. In fact, in the next few versions of BuddyPress, we are likely to begin deprecating it more aggressively; see #5390.

If there are aspects of the WP bar that you think are worse than the Buddybar, please feel free to point them out. We think the WP bar is better in pretty much every way, but it's possible that we're missing something :)

[lenasterg]

Hi. There is a bug on
bp-notifications/bp-notifications-buddybar.php which on debug mode gives

<b>Warning</b>: number_format() expects parameter 1 to be double, array given in <b>/wp-includes/functions.php</b> on line <b>155</b><br />

Maybe this is related.
I attach the patch.

[lenasterg]

notifications buddybar patch

[lenasterg]

Or another solution is to replace at line 30 of bp-notifications/bp-notifications-buddybar.php the bp_notifications_get_notifications_for_user()

if ( $notifications = bp_notifications_get_notifications_for_user( bp_loggedin_user_id() ) ) : ?>

with bp_notifications_get_unread_notification_count() which will return integer.

[boonebgorges]

Thanks, lenasterg. This looks right.

[boonebgorges]

In 7913:

Use the correct function to get notification unread count for buddybar

Fixes #5403

Props lenasterg

[lenasterg]

@boonebgorges,
I noticed that in various places the number_format_i18n() is used. Is this correct or should be changed to bp_core_number_format()?

[lenasterg]

Unfontunatelly using bp_notifications_get_unread_notification_count() created bug on line 39 of the same file, in the loop of displaying the unread notifications. So I think the patch is more appropriate to use.

[boonebgorges]

In 7920:

Fix Buddybar notification formatting bug introduced in r7913

Fixes #5403

[elpix]

So what I have to do ?
Just wait for the next release of BP ?

[lenasterg]

@elpix hi.
I think you would be OK if you replace in the /buddypress/bp-notifications/bp-notifications-buddybar.php file the function bp_notifications_buddybar_menu(){...
with the version which is in ​https://buddypress.trac.wordpress.org/browser/trunk/bp-notifications/bp-notifications-buddybar.php from line 21 to 56.