Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

#5396 closed defect (bug) (fixed)

Improve string escaping in wp-admin/Profile

Reported by: imath Owned by: imath
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit
Cc:

Description

As DJPaul explained me : it's better to move the esc_html closer to the output on the screen.

Attachments (1)

5396.diff (4.2 KB) - added by imath 8 years ago.

Download all attachments as: .zip

Change History (3)

@imath
8 years ago

#1 @boonebgorges
8 years ago

  • Keywords commit added

The esc_url() change seems like the only significant one here. The other moves are just for the (good) convention of escaping just before output; they're functionally identical. But yes, please go for it.

#2 @imath
8 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 7867:

Improve string escaping in wp-admin/Profile

Props DJPaul

Fixes #5396

Note: See TracTickets for help on using tickets.