Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#5383 closed enhancement (fixed)

Inconsistent use of <strong> in _get_profile_stats() markup

Reported by: danbp's profile danbp Owned by: boonebgorges's profile boonebgorges
Milestone: 2.0 Priority: low
Severity: trivial Version:
Component: I18N Keywords:
Cc:

Description

on line 1256, there is a plural form for "site"
The singular is 1 site
The plural is <strong>%s</strong> sites

Do we need a strong tag in the source for the plural form if there is none for the singular ?

IMO it's not necessary, each translator can anyway add the appropriate html he need, if ever !

Change History (3)

#1 @boonebgorges
10 years ago

  • Keywords needs-docs removed
  • Milestone changed from Awaiting Review to 2.0
  • Summary changed from pot #7825 plural output to Inconsistent use of <strong> in _get_profile_stats() markup
  • Type changed from task to enhancement
  • Version 1.9.2 deleted

I think the <strong> tags are appropriate, but I think that (a) we should be consistent, and (b) we should try to avoid putting HTML tags into gettext calls when possible. Thanks for bringing this up.

#2 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7828:

Make the _get_profile_stats() output markup more consistent and translator-friendly

  • Apply <strong> tag in both plural and singular forms
  • Don't include <strong> tag in gettext string

Fixes #5383

Props danbp

#3 @DJPaul
8 years ago

  • Component changed from Locale - i18n to I18N
Note: See TracTickets for help on using tickets.