Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 10 years ago

#5383 closed enhancement (fixed)

Inconsistent use of <strong> in _get_profile_stats() markup

Reported by: danbp Owned by: boonebgorges
Priority: low Milestone: 2.0
Component: I18N Version:
Severity: trivial Keywords:
Cc:

Description

on line 1256, there is a plural form for "site"
The singular is 1 site
The plural is <strong>%s</strong> sites

Do we need a strong tag in the source for the plural form if there is none for the singular ?

IMO it's not necessary, each translator can anyway add the appropriate html he need, if ever !

Change History (3)

#1 @boonebgorges
12 years ago

  • Keywords needs-docs removed
  • Milestone Awaiting Review2.0
  • Summary pot #7825 plural outputInconsistent use of <strong> in _get_profile_stats() markup
  • Type taskenhancement
  • Version 1.9.2

I think the <strong> tags are appropriate, but I think that (a) we should be consistent, and (b) we should try to avoid putting HTML tags into gettext calls when possible. Thanks for bringing this up.

#2 @boonebgorges
12 years ago

  • Owner set to boonebgorges
  • Resolutionfixed
  • Status newclosed

In 7828:

Make the _get_profile_stats() output markup more consistent and translator-friendly

  • Apply <strong> tag in both plural and singular forms
  • Don't include <strong> tag in gettext string

Fixes #5383

Props danbp

#3 @DJPaul
10 years ago

  • Component Locale - i18nI18N
Note: See TracTickets for help on using tickets.