Skip to:

Opened 10 years ago

Closed 10 years ago

#5371 closed enhancement (fixed)

Activity comment query still joins against users table

Reported by: boonebgorges's profile boonebgorges Owned by: boonebgorges's profile boonebgorges
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Activity Keywords:


In [7765], primary activity queries were split into ID lookups and data lookups. The same should happen in activity comment queries (get_activity_comments())

Change History (2)

#1 @boonebgorges
10 years ago

In 7776:

Introduce BP_Activity_Activity::append_user_fullname()

Previously, the appending of xprofile fullnames was done inline in the get()
method. This changeset breaks it into a standalone method, so it can be used
elsewhere in the class.

See #5371

#2 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7777:

Split activity comments query into searate ID query

This eliminates joins against the global user table, and also centralizes
caching for individual activity items.

Fixes #5371

Note: See TracTickets for help on using tickets.