Skip to:

Opened 10 years ago

Closed 10 years ago

#5369 closed defect (bug) (fixed)

Activity comment cache is broken

Reported by: boonebgorges's profile boonebgorges Owned by: boonebgorges's profile boonebgorges
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Activity Keywords:


We attempt to use the object cache in BP_Activity_Activity::get_activity_comments(), but it's incorrectly implemented. We are inconsistent about the use of the 'bp' group, and there are some issues with the way that successful empty queries are cached.

Change History (1)

#1 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7773:

Fix persistent caching for BP_Activity_Activity::get_activity_comments()

  • Use the 'bp' cache group consistently
  • When a query shows that an activity item has no comments, do not cache the boolean value false. This will cause a cache miss the next time around. Instead, store the string 'none', and then convert it to false when requerying.

Fixes #5369

Note: See TracTickets for help on using tickets.