Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #5367, comment 21


Ignore:
Timestamp:
11/02/2014 03:10:19 PM (5 years ago)
Author:
johnjamesjacoby
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5367, comment 21

    initial v1  
    33WordPress is choosing to go a similar route as this patch with `wp_is_trusted_network()`, which has already proven to not be flexible enough for our use case. We need either a global variable in the BuddyPress singleton for `installation_type` or a white-listed array of types to hint at the application what kind of approach should be enforced regardless of what environment variables tell us.
    44
    5 This is to say, we can make several assumptions based on constants and activation types, but there is no guarantee our assumptions are accurate. Just because `MULTISITE` is true, and BuddyPress is network activated, doesn't mean there aren't other networks, doesn't mean network admins can edit all users outside of their networks, etc… We should audit common uses, ensure we are providing sane default experiences, and make sure we aren't escalating privileges or allowing members to access to areas and functionality they wouldn't othherwise have in WorsPress, unless we explicitly design it to for some greater purpose (as there are always exceptions to these rules.)
     5This is to say, we can make several assumptions based on constants and activation types, but there is no guarantee our assumptions are accurate. Just because `MULTISITE` is true, and BuddyPress is network activated, doesn't mean there aren't other networks, doesn't mean network admins can edit all users outside of their networks, etc… We should audit common uses, ensure we are providing sane default experiences, and make sure we aren't escalating privileges or allowing members to access areas and functionality they wouldn't otherwise have in WordPress, unless we explicitly design it to for some greater purpose (as there are always exceptions to these rules.)
    66