Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#5361 closed defect (bug) (fixed)

BuddyPress not honoring BP_IGNORE_DEPRECATED

Reported by: Denis-de-Bernardy Owned by: boonebgorges
Milestone: 2.0 Priority: normal
Severity: normal Version: 1.9.1
Component: Core Keywords:
Cc: ddebernardy@…

Description

There's a define mentioned in the codex that reportedly prevents the loading of deprecated code.

While investigating why buddypress/bp-templates/bp-legacy/js/buddypress.js?ver=1.9.1-7716 was getting loaded in spite of the constant being defined to true, I did to locate the constant in the source code to see what it was supposed to do. Couldn't find it, no luck.

There also seems to be a $bp->load_deprecated thingy in there, which apparently cannot be overridden.

Change History (3)

#1 @Denis-de-Bernardy
6 years ago

  • Cc ddebernardy@… added

#2 @boonebgorges
6 years ago

  • Milestone changed from Awaiting Review to 2.0

Hm, looks like BP_IGNORE_DEPRECATED last appeared in version 1.1 of BuddyPress, several years ago.

You appear to be correct that there's no way to disable the loading of deprecated functions. We may as well reintroduce the old BP_IGNORE_DEPRECATED constant to fix this.

#3 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7767:

Make it possible to prevent deprecated functions from loading

Until version 1.1, BP had a constant BP_IGNORE_DEPRECATED that kept BP from
loading the files that contain deprecated functions. This was mysteriously
removed for 1.2. Meanwhile, it was impossible to prevent deprecated functions
from being loaded.

This changeset reintroduces BP_IGNORE_DEPRECATED and uses it to decide whether
deprecated functions should be loaded. There is also a new filter
'bp_ignore_deprecated' that serves a similar purpose, but in filter form.

Fixes #5361

Note: See TracTickets for help on using tickets.