Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 3 years ago

#5358 closed defect (bug) (fixed)

Add $add_root as property of $bp

Reported by: needle Owned by:
Priority: normal Milestone: 12.0.0
Component: Core Version: 1.9.1
Severity: normal Keywords:
Cc:

Description

In bp-core-functions.php, line 504 in the bp_core_add_root_component() function throws "Indirect modification of overloaded property" notice, similarly to ​https://buddypress.trac.wordpress.org/ticket/5305

Change History (10)

#1 @r-a-y
13 years ago

  • Keywords dev-feedback added

It seems to me that we shouldn't even need $bp->add_root.

We should merge the bp_core_add_root_component() and bp_core_create_root_component_page() functions together since $bp->add_root doesn't do anything without the bp_core_create_root_component_page() function.

#2 @DJPaul
12 years ago

  • Milestone Awaiting Review → 2.1

#3 @DJPaul
12 years ago

  • Keywords needs-patch added; dev-feedback removed
  • Milestone 2.1 → 2.2

#4 @DJPaul
12 years ago

  • Milestone 2.2 → Future Release

#5 @tw2113
9 years ago

Unless these two are dynamically called and named, I'm not seeing them used anywhere in core at the moment.

More than willing to be wrong.

#6 @espellcaste
5 years ago

  • Milestone Awaiting Contributions → 11.0.0
  • Owner set to espellcaste
  • Status new → assigned

#7 @espellcaste
4 years ago

  • Milestone 11.0.0 → Up Next

Bumping this ticket to the next version so that I can look at this more closely. :)

#8 @imath
4 years ago

  • Milestone Up Next → 12.0.0

#9 @espellcaste
4 years ago

  • Owner espellcaste removed

#10 @imath
3 years ago

  • Keywords needs-patch removed
  • Resolution → fixed
  • Status assigned → closed

This function has been deprecated in 12.0 and is now only available from the BP Classic plugin. I’ll work on this issue from there: ​https://github.com/buddypress/bp-classic/issues/11

Note: See TracTickets for help on using tickets.