Skip to:
Content

BuddyPress.org

Opened 6 years ago

Last modified 2 years ago

#5358 new defect (bug)

Add $add_root as property of $bp

Reported by: needle Owned by:
Milestone: Awaiting Contributions Priority: normal
Severity: normal Version: 1.9.1
Component: Core Keywords: needs-patch
Cc:

Description

In bp-core-functions.php, line 504 in the bp_core_add_root_component() function throws "Indirect modification of overloaded property" notice, similarly to https://buddypress.trac.wordpress.org/ticket/5305

Change History (5)

#1 @r-a-y
6 years ago

  • Keywords dev-feedback added

It seems to me that we shouldn't even need $bp->add_root.

We should merge the bp_core_add_root_component() and bp_core_create_root_component_page() functions together since $bp->add_root doesn't do anything without the bp_core_create_root_component_page() function.

#2 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to 2.1

#3 @DJPaul
5 years ago

  • Keywords needs-patch added; dev-feedback removed
  • Milestone changed from 2.1 to 2.2

#4 @DJPaul
5 years ago

  • Milestone changed from 2.2 to Future Release

#5 @tw2113
2 years ago

Unless these two are dynamically called and named, I'm not seeing them used anywhere in core at the moment.

More than willing to be wrong.

Note: See TracTickets for help on using tickets.