Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#5355 closed defect (bug) (wontfix)

Filtering classes added in bp_core_fetch_avatar()

Reported by: henry.wright Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.9.1
Component: Core Keywords:
Cc:

Description

This is probably a very low priority ticket but there seems to be no way of filtering the classes automatically added to member's avatars in the bp_core_fetch_avatar() function.

See line 351 of bp-core-avatars.php in BP v1.9.1

Classes such as photo and user-31-avatar can't be modified (or removed - which was my aim)

Change History (3)

#1 @imath
6 years ago

Hi henry.wright

I think there's a reason why these classes are there: see #4503
For instance long time ago i've built a script that was using the class user-[user_id]-avatar to load a customized hovercard. I guess some plugins are expecting these classes, so i would advise you to leave them.

You may have seen, you can add new classes using the filter bp_core_avatar_class, a possible way to ease your need to remove the targeted classes would be to move this filter under the line you're mentioning. But i'm not sure it's a good idea, i'd like to have other core team member's opinion about it.

#2 @henry.wright
6 years ago

Hi imath,

Thanks for looking at this ticket. My aim was to remove unnecessary HTML from the page. But as you've pointed out, the avatar classes are necessary. Please feel free to close the request.

#3 @imath
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.