Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5330 closed defect (bug) (fixed)

Group avatars should not be so dependent of the xprofile component settings

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 2.0 Priority: normal
Severity: normal Version: 1.9.1
Component: Groups Keywords: has-patch 2nd-opinion commit
Cc:

Description

Hello,

If you deactivate the profile component, then go into the BuddyPress settings to save them, then Group avatar functionality is no more available (create step or edit step).

I've attached a patch that adds the avatar setting to xprofile settings if xprofile is active else to groups settings if groups component is active.

But, i think this might not be the best solution. Maybe things should be more separated as for instance an admin may wish to disable user's avatar uploads and rely on Gravatar but allow group avatar uploads.

If Avatar uploads is disabled, as group avatars can't be customized else than using a generated avatar (avatar, retro...), some users may want to completely avoid the display of group avatars in templates to only keep the name of the group. For a corporate project i'm working on for instance, it's the case. It may be interesting to deal with this particular need..

What is your opinion ?

Attachments (1)

5330.diff (2.3 KB) - added by imath 10 years ago.

Download all attachments as: .zip

Change History (5)

@imath
10 years ago

#1 follow-up: @boonebgorges
10 years ago

I'd be happy with a separate section for Avatar settings. If we're going to do that anyway, then I think it does make sense to allow for multiple different settings for Profile and Group avatars. Maybe something like:

AVATARS

Profile   [x] Local uploads    [x] Gravatar
Groups    [x] Local uploads    [x] Gravatar

#2 in reply to: ↑ 1 @imath
10 years ago

Replying to boonebgorges:

I'd be happy with a separate section for Avatar settings.

I agree, and at the same time i can't help thinking of avatars as some kind of 'attachment' to users, groups, blogs that we could group into a component to manage others components attachment...

#3 @DJPaul
10 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.0

#4 @imath
10 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 7743:

Makes group avatars not dependant of xprofile component settings

Avatar uploads setting is by default attached to xprofile settings. In case this component is disable and groups component is active, the avatar uploads setting will be attached to groups in order to keep on allowing avatar uploads for groups.

Fixes #5330

Note: See TracTickets for help on using tickets.