Skip to:
Content

BuddyPress.org

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#533 closed defect (bug) (fixed)

Pagination on Friends Page Broken

Reported by: trent's profile trent Owned by: apeatling's profile apeatling
Milestone: Priority: major
Severity: Version: 1.0
Component: Keywords: my-friends, friends
Cc: mburp

Description

If you are viewing the "friends" page for a member it shows the first 10 friends just fine. If you click on the next page or "2" in navigation, ajax works but displays no additional results. You can see this in action at:

http://testbp.org/members/trent/friends

Change History (15)

#1 @apeatling
16 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1155]) Fixes #533

#2 @mburp
16 years ago

  • Cc mburp added
  • Keywords my-friends friends added
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version set to 1.0

I had this problem in an earlier post RC1 svn, saw this and updated to today's version - but it had no effect. I show three pages of friends, 10 on the first page, but when I click the link for page 2, 3 or next, the page comes up empty.

#3 @apeatling
16 years ago

  • Resolution set to worksforme
  • Status changed from reopened to closed

Have you updated your BuddyPress member theme? This fix is theme based as well.

You must have a <?php wp_nonce_field() ?> call in your template file.

#4 @mburp
16 years ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened

Yes. I updated both the member and home themes when I updated BuddyPress. Where exactly should the <?php wp_nonce_field() ?> call be located in the friends template files? I've checked mine against the current svn and the two are identical - and neither includes this call.

As a general rule, it would be very helpful if you could tell us where something is supposed to be when you send us off to search for it. I used ExamDiff the other night to compare every file in the svn I was upgrading to against the equivalent file in my install. I could have done this again today and may yet do it if I need to in order to resolve this problem, but since you presumably know where this call should be located ... All I could gather from the above was that it should be in one of the friends template files.

#5 @mburp
16 years ago

I found 8 instances of <?php wp_nonce_field() ?> in buddypress-member tmplate files from the current svn. All are present in my current install. None are in friends files.

#6 @apeatling
16 years ago

If you updated the themes, you will be fine.

When you click the pag links, do you see a "-" on the page? (Without the quotes)

#7 @apeatling
16 years ago

  • Priority changed from critical to major

#8 @mburp
16 years ago

Well, I did update the themes, but I'm not yet fine. When I click the page link I do not see a '-' on the page. The page links look fine to me, being in the form 'http://unitarsalgo.unitarius-halo.net/members/michael/friends?fpage=2'.

#9 @mburp
16 years ago

Does this tell us something?

When I go to page 2 of my Friends pages and I don't find friends 11 - 20 listed (I don't find anyone listed) I can check the page source and still find Friends 1 - 10 in the source but no one beyond that and no one shows on page 2 - or 3.

Comparing Friends source to Members - which works great - there's no call to the ajax-loader image or to the wpnonce-member-filter on the Friends pages.

#10 @mburp
16 years ago

... should have written "no call to wpnonce in any form on the Friends pages."

#11 @apeatling
16 years ago

Try the latest trunk. The original problem is fixed, as you can see on testbp.org.

#12 @mburp
16 years ago

It looks like this is a browser dependent problem. The Friends pages at testbp.org are working in IE 7 - as they are on my site - but not in Firefox 2.0.20.

#13 @mburp
16 years ago

Its working in Firefox 3.0.7.

#14 @apeatling
16 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

I'm not worried about FF2.

#15 @(none)
16 years ago

  • Milestone Default Member Theme 1.0 deleted

Milestone Default Member Theme 1.0 deleted

Note: See TracTickets for help on using tickets.