Opened 11 years ago
Closed 11 years ago
#5329 closed defect (bug) (fixed)
Each time the load more link is clicked, the activity-loop-form is generated
Reported by: | imath | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 2.0 | Priority: | low |
Severity: | minor | Version: | 1.9.1 |
Component: | Activity | Keywords: | has-patch 2nd-opinion commit |
Cc: |
Description
In the activity-loop template, as the form id="activity-loop-form"
is not surrounded by a $_POST['page']
check, it is generated at each click on the load more link.
Although it doesn't break anything, i think we should avoid this unless there is a reason i haven't figured out.
The patch is also taking care of BP Default.
Attachments (1)
Change History (5)
#2
in reply to:
↑ 1
@
11 years ago
- Milestone changed from 1.9.2 to 2.0
Replying to boonebgorges:
Is this a regression in 1.9? If not, let's do it for 2.0.
I think it's there for a long time ;) so it's not a regression in 1.9 and i agree about 2.0 milestone
Is the check of $_POSTpage? supposed to be a test for whether it's an AJAX request?
Yes, on a similar way the ul tag is not displayed in such a case
Is this a regression in 1.9? If not, let's do it for 2.0.
Is the check of $_POSTpage? supposed to be a test for whether it's an AJAX request?