Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 12 years ago

#5323 closed enhancement (fixed)

In the "Pages" meta box of Menu Administration Screen, exclude Activate and Register pages

Reported by: imath Owned by: imath
Priority: low Milestone: 2.0
Component: Core Version: 1.9.1
Severity: minor Keywords: has-patch commit
Cc:

Description

Since BuddyPress user nav menu, i think we should filter the list of links displayed in the "Pages" meta box to avoid displaying :

  • the Activation page as it's only used to activate an account.
  • the Register page, because it can introduce some confusion with the Register BuddyPress user nav menu item.

Attachments (2)

5323.diff (953 bytes ) - added by imath 13 years ago.
5323.01.diff (1.5 KB ) - added by imath 12 years ago.

Download all attachments as: .zip

Change History (8)

@imath
13 years ago

#1 @imath
13 years ago

  • Summary In the "Pages" meta box of Menu Administration Screens, exclude some Activate and Register pagesIn the "Pages" meta box of Menu Administration Screen, exclude Activate and Register pages

#2 @DJPaul
12 years ago

Some feedback about the patch:

  • $pages should be initialised to an empty array.
  • The function would be approx. 117% better if it had phpDoc.
  • Minor code standards point: !empty should be ! empty.

Other than that, looks good.

#3 @boonebgorges
12 years ago

  • Keywords 2nd-opinion removed
  • Milestone Awaiting Review2.0

+1 to everything DJPaul says. Also, no blank line between the end of the function and the add_filter() call. Otherwise, let's do it.

@imath
12 years ago

#4 @imath
12 years ago

Thanks DJPaul, boonebgorges
just added 5323.01.diff to improve the patch.

#5 @boonebgorges
12 years ago

  • Keywords commit added

#6 @imath
12 years ago

  • Owner set to imath
  • Resolutionfixed
  • Status newclosed

In 7741:

Prevents Activate and Register pages from showing in the Pages meta box of the Menu Administration screen.

In the same way these pages are not displayed on the page listings, they will be hidden from the available items of the Pages meta box in the menus administration. This also avoids confusion with the register item of BuddyPress dynamic links.

Fixes #5323

Note: See TracTickets for help on using tickets.