Skip to:

Opened 10 years ago

Closed 10 years ago

#5314 closed enhancement (fixed)

filter for friends notification

Reported by: mpa4hu's profile mpa4hu Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Toolbar & Notifications Keywords:


mensions notification has a filter which provides handy variables.

but `friends_format_notifications` does not.
I think it will be good for function to provide `$item_id` and `$format`

Change History (6)

#1 @johnjamesjacoby
10 years ago

  • Component changed from Core to Notifications
  • Milestone changed from Awaiting Review to 2.0
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

#2 @r-a-y
10 years ago

In 8169:

Friends: Pass $item_id as an argument for notification format filters.

Props mpa4hu

See #5314

#3 @r-a-y
10 years ago

  • Keywords needs-testing added

mpa4hu - I've added the $item_id as an argument for the notification filters.

As for $format, I don't think that variable is necessary.

You can do a check for the format by checking if the notification is an array. If it is an array, then the format is 'array'. If not, then the format is 'string'.

Leaving it open for feedback.

#4 @r-a-y
10 years ago

  • Keywords 2nd-opinion added; needs-testing removed

#5 @mpa4hu
10 years ago

I have not thought about checking array, thanks that works just fine!

#6 @r-a-y
10 years ago

  • Keywords 2nd-opinion removed
  • Resolution set to fixed
  • Status changed from assigned to closed

Thanks for confirming. Closing this one!

Note: See TracTickets for help on using tickets.