Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#5306 closed enhancement (fixed)

Port bbp_parse_args() from bbPress

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

Let's port bbp_parse_args() from bbPress, and replace wp_parse_args().

There are approximately 264 usages, so this will be an ongoing ticket in the 2.0 milestone.

Attachments (1)

5306.template_loops.01.patch (4.1 KB) - added by r-a-y 8 years ago.

Download all attachments as: .zip

Change History (12)

#1 @johnjamesjacoby
8 years ago

In 7704:

Introduce bp_parse_args() to bp-core-functions.php, ported from bbPress. See #5306.

#3 @r-a-y
8 years ago

  • Keywords has-patch added; needs-patch commit removed

template_loops.01.patch replaces all usage of wp_parse_args() in our template loops.

This follows the convention set in r7924 for the bp_has_message_threads() template loop. Should be pretty straightforward, but just wanted to make sure this is good to go.

This ticket was mentioned in IRC in #buddypress-dev by r-a-y. View the logs.


8 years ago

#5 @johnjamesjacoby
8 years ago

  • Keywords commit added

This looks great!

#6 @r-a-y
8 years ago

In 8142:

Replace wp_parse_args() with bp_parse_args() for all template loops.

bp_parse_args() allows developers to filter the template arguments
before the loop is rendered. This will allow for greater
flexibility to manipulate template loops in plugins.

See #5306

#7 @r-a-y
8 years ago

  • Keywords commit removed
  • Milestone changed from 2.0 to 2.1

Let's iterate on this for 2.1.

#8 @r-a-y
8 years ago

  • Keywords has-patch removed

#9 @DJPaul
8 years ago

  • Milestone changed from 2.1 to Future Release

#10 @johnjamesjacoby
8 years ago

  • Milestone changed from Future Release to 2.2
  • Resolution set to fixed
  • Status changed from new to closed

Closing as fixed.

The function was ported and we can update wp_parse_args usages ad infinitum.

#11 @DJPaul
6 years ago

  • Type changed from task to enhancement
Note: See TracTickets for help on using tickets.