Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5291 closed enhancement (fixed)

Dashicons support for WordPress 3.8

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.9 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Cc:

Description

Let's use the Buddicons supplied by Ben for top level menus and the components settings page.

Haven't figured out a way to make it backwards compatible without having separate stylesheets and making a decision in PHP, which seems like more trouble than it's worth for icons IMO.

Attachments (2)

5291.patch (7.7 KB) - added by johnjamesjacoby 10 years ago.
5291.02.patch (19.5 KB) - added by boonebgorges 10 years ago.

Download all attachments as: .zip

Change History (4)

#1 @boonebgorges
10 years ago

Using the technique suggested here by nacin http://make.wordpress.org/ui/2013/11/19/targeting-the-new-dashboard-design-in-a-post-mp6-world/ (targeting the old versions rather than new ones), 5291.02.patch provides a CSS-only method of backward compatibility.

I also took the liberty to fix the Components icons for Firefox. It turns out that, because FF doesn't support background-position-x and background-position-y, they have never worked properly! I'm pretty shocked this has never been reported. Anyway, simple fix.

This is looking good and I don't see a problem including it in 1.9, but I would like to have another set of eyes on it (especially if you can check on a 3.7 *and* a 3.8 rig).

#2 @johnjamesjacoby
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In 7667:

WordPress 3.8 support for top level menu icons. Props boonebgorges. Fixes #5291.

Note: See TracTickets for help on using tickets.