Skip to:
Content

Opened 4 years ago

Closed 21 months ago

#5260 closed enhancement (fixed)

Select All link missing in BuddyPress Menu Selection

Reported by: mrjarbenne Owned by: tw2113
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Cc:

Description

In the other Appearance/Menu categories (Pages, Posts, Categories, etc.) there is a link on the bottom left that allows you to select all of the items to add them in bulk to the selected menu. The BuddyPress instance of this menu in BP 1.9B1 is slightly different because of the separation between logged in and logged out links, so perhaps two "select all" links would be appropriate (one after each subset), but I think it makes sense to have one.

Attachments (1)

5260-select-all-menu.diff (1.2 KB) - added by tw2113 22 months ago.

Download all attachments as: .zip

Change History (9)

#1 @DJPaul
4 years ago

  • Component changed from Core to Administration
  • Milestone changed from Awaiting Review to Future Release

Makes sense, but too late for 1.9. Maybe we can add it in for 2.0.

#2 @tw2113
22 months ago

  • Keywords has-patch added

Due to how the javascript is done with WordPress core, we're not going to be able to easily handle two separate "Select all" links, but we can easily handle one. Attached is a screenshot gleaned from WordPress' callbacks for the menu sections. Hopefully this is well enough not to worry about.

#3 @DJPaul
22 months ago

  • Milestone changed from Future Release to 2.7

If you stick a patch on a *bug fix* ticket, move it to the current active release so people will more likely see it for review.

This ticket was mentioned in Slack in #buddypress by tw2113. View the logs.


22 months ago

#5 @tw2113
22 months ago

  • Owner set to tw2113
  • Status changed from new to assigned

This ticket was mentioned in Slack in #buddypress by mercime. View the logs.


21 months ago

#7 @mercime
21 months ago

Hi @tw2113. Tested the patch and it's working well in all menu locations :)

#8 @tw2113
21 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 11059:

Add a "select all" link to the BuddyPress menu section for the WP Nav Menu system.

Fixes #5260.

Note: See TracTickets for help on using tickets.