Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5239 closed defect (bug) (fixed)

New 1.9 feature : BuddyPress links box to nav-menus.php troubles

Reported by: imath's profile imath Owned by: boonebgorges's profile boonebgorges
Milestone: 1.9 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch
Cc:

Description

Hi,

I've just checked this great new feature introduced in [7427] in WordPress 3.7.1 & BuddyPress 1.9-alpha-7287 and found two troubles.

1/ In bp-core/bp-core-functions.php function bp_nav_menu_get_loggedin_pages() at line the cached variable returned is causing an error as soon as more than one user nav link has been set in the wp_nav_menu. I think the reason is the variable should be buddypress()->wp_nav_menu_items->loggedin instead of buddypress()->wp_nav_menu_items

2/ From the WordPress Appearance/Menus Administration screen, the checkbox "Log in" in the second box for "Logged-Out links" is not added to the menu when checked. I think the reason is that the div tabs-panel-posttype-<?php echo $post_type_name; ?>-loggedout doesn't have a tabs-panel-active class.

So i suggest the diff attached to this ticket as it seems to correct these two troubles.

Attachments (1)

5239.diff (2.2 KB) - added by imath 10 years ago.

Download all attachments as: .zip

Change History (4)

@imath
10 years ago

#1 @r-a-y
10 years ago

  • Milestone changed from Awaiting Review to 1.9
  • Version 1.8.1 deleted

Great catch, imath.

When we dropped the tabs in the nav menu metabox, the CSS classes were not properly adjusted.

#2 @boonebgorges
10 years ago

In 7566:

Fix incorrect property reference in bp_nav_menu_get_loggedin_pages()

See #5239

Props imath

#3 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7567:

Fix dynamic class names for nav_menu metabox

The dynamic setting of the tabs-panel-active class was a remnant of an
earlier, tabbed version of the nav_menu feature.

Fixes #5239

Props imath

Note: See TracTickets for help on using tickets.