#5228 closed defect (bug) (fixed)
Wrong total members count due to number_format_i18n
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 1.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | needs-patch reporter-feedback |
Cc: |
Description
number_format_i18n doesn't work as it should on bp-members-template.php on line 347.
I'm using the italian internationalization and I have 8916 members in the database, so 8916 becomes 8.916, then (maybe there is an (int) filter) becomes 9... so it displays a total of 9 members.
To fix remove number_format_i18n on the lines 347, 349, 351, 353.
Attachments (1)
Change History (11)
#2
@
11 years ago
- Owner set to boonebgorges
- Resolution set to fixed
- Status changed from new to closed
In 7513:
#3
@
11 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Good :) but I updated to svn 7515 and even if on members page the total count is now correct, there are still wrong counts, like on activity page .activity-type-tabs role="navigation" :(
#4
@
11 years ago
- Keywords reporter-feedback added; has-patch removed
there are still wrong counts
Could you give a list of the places where you see incorrect counts?
#5
@
11 years ago
Seems that the only left was the one on activity page, but I cannot test with groups because I don't have many... then I'm realising that for groups there is no count transient value stored on options table like for members.
#8
@
11 years ago
Sorry for replying again here, but I guess that I should report that the new behavior is not unique at the moment. There are places where the number is formatted, and places where not. I will attach a screenshot: the first one is the the activity page, the second one the users. In my theme the sidebar on the left side is the subnav.
Yep. Not sure why we have our own bp_core_number_format as it doesn't add much value, but that just uses number_format_i18n.