Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #5220, comment 32


Ignore:
Timestamp:
03/27/2014 09:52:24 AM (6 years ago)
Author:
DJPaul
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5220, comment 32

    initial v1  
    11Added 05.patch, which pending final testing, I will be committing later today. It includes a couple more unit tests and more assertions for existing tests. I caught a few more bugs like negative numbers not being accepted by the number field, and some interesting differences between the tests passing integers to the xProfile functions, but the app passing integers as strings. I've put in a quick bodge for that for now, but it points to an area of future improvement (giving the field type class a chance to pre-sanitise the input for a particular field).
     2
     3Notably I re-implemented Ray's fixed for 0 values as I don't want to set the number class as accepts_null_values. That's already kind of hacky and it's intended specifically for the dropdown box etc, and I don't want it to be used just to be able to store 0 as the field value. :) Recent commits r8163 and r8165 have formed part of the preparation for this patch.