Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#5156 closed defect (bug) (fixed)

Theme compat content cannot be filtered

Reported by: ddean Owned by: r-a-y
Milestone: 1.9 Priority: normal
Severity: normal Version: 1.7
Component: Appearance - Template Pack Keywords: has-patch
Cc: david@…

Description

Calls to bp_buffer_template_part hooked to the bp_replace_the_content filter echo content rather than returning it.

Content is immediately displayed instead of being passed along to later functions hooking bp_replace_the_content.

Attachments (2)

bp-groups-screens.php.patch (1.0 KB) - added by ddean 7 years ago.
all-screens.patch (4.1 KB) - added by ddean 7 years ago.
Expanded to include all components

Download all attachments as: .zip

Change History (7)

#1 @ddean
7 years ago

  • Cc david@… added

I'm attaching a patch for Groups as an example, but it's like this for the Activity, Blogs, Forums, Groups, and Members components.

#2 @r-a-y
7 years ago

  • Keywords has-patch needs-refresh added
  • Milestone changed from Awaiting Review to 1.8.2
  • Version set to 1.7

Good catch. We should do this for all components like you stated, ddean.

@ddean
7 years ago

Expanded to include all components

#3 @r-a-y
7 years ago

  • Keywords needs-refresh removed
  • Milestone changed from 1.8.2 to 1.9

Thanks for the refresh, ddean.

#4 @r-a-y
7 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 7386:

Return contents instead of echoing during theme compat output buffer.

When using the 'bp_replace_the_content' filter, we need to return the
contents instead of echoing.

Thus, this commit changes all bp_buffer_template_part() calls to
return instead of echo.

Fixes #5156. Props ddean.

#5 @johnjamesjacoby
6 years ago

  • Component changed from Component - Any/All to Appearance - Template Pack
Note: See TracTickets for help on using tickets.