Add hooks to modify display of entire comment

[lchski]

Currently the way comments are laid out, if someone were to want to modify the display of an entire comment (say, wrap it in a div), they'd have to hook into bp_before_activity_comment and bp_after_activity_comment.

The unfortunate side effect of this is that the entire comment would be wrapped in the div -- including all children (replies) of that comment.

This is not desirable behaviour, and it'd be great to have a hook that could be used to modify the content of just one comment, ignoring its children.

This would mean putting the first hook before .acomment-avatar, and the second hook after .accomment-options.

Thoughts? Could this be a suitable improvement. I'll work on the change if people are willing and believe it to be worthwhile.

[DJPaul]

In the activity/comment.php template? Seems reasonable to me; naming the action names as "early" and "late" might make sense as a pattern to use for actions inside loops inside blocks of HTML.

How did you run into this problem? I assume if you want to hook it, you aren't working on a theme; are you building a plugin?... or are you building out a theme? :)

[boonebgorges]

The improvement sounds fine to me, though I'm not totally sure how you'll prevent the recursion issue with a simple hook. Happy to see a patch, though!

[r-a-y]

it'd be great to have a hook that could be used to modify the content of just one comment, ignoring its children.

If you are manipulating this with hooks, then I believe you can just check the current activity comment ID before doing your manipulation.

eg.

function my_add_div_to_specific_activity_comment() {

	// add a open <div> element if the activity comment ID equals 1
	if ( bp_get_activity_comment_id() == 1 ) {
		echo '<div>';
	}

}
add_action( 'bp_before_activity_comment', 'my_add_div_to_specific_activity_comment' );

You'll have to use the same logic when closing the <div> as well.

Let me know if this is enough to address your issue.

---

Although, I do agree with this:

This would mean putting the first hook before .acomment-avatar, and the second hook after .accomment-options.

These would have to be new hooks. We can't move existing hooks due to backwards-compatibility reasons.

[boonebgorges]

Moving out of a specific milestone, pending reporter feedback.

[DJPaul]

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

[DJPaul]

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.