Skip to:

Opened 11 years ago

Closed 11 years ago

#5132 closed defect (bug) (fixed)

Provide fallback for group invite status in group settings form handler

Reported by: boonebgorges's profile boonebgorges Owned by: boonebgorges's profile boonebgorges
Milestone: 1.9 Priority: lowest
Severity: trivial Version:
Component: Groups Keywords:


In groups_screen_group_admin_settings(), we should check whether $_POST['group-invite-status'] is set before checking it against the status whitelist, to avoid PHP warnings. Sites that are using BP's core templates for the group edit pages will have this input in the edit form, but custom templates that are a bit older will not, resulting in PHP warnings.

Change History (1)

#1 @boonebgorges
11 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7343:

Fix PHP notice in groups_screen_group_admin_settings()

To support legacy group edit templates, we must check to see that
$_POSTgroup-invite-status? is populated before sanitizing the value
against our status whitelist.

Fixes #5132

Note: See TracTickets for help on using tickets.