Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#5131 closed defect (bug) (wontfix)

id or class for item-body - what should be used?

Reported by: slaFFik Owned by:
Priority: normal Milestone:
Component: Appearance - Template Pack Version: 1.8.1
Severity: normal Keywords:
Cc: slaffik@…

Description

Is it ok, that sometimes in the templates we have #item-body (on single group page) and sometimes .item-body (on group creation steps)?
It's confusing for theming and styling.

Change History (2)

#1 @slaFFik
13 years ago

So I need to do this

#buddypress .item-body h4,
#buddypress #item-body h4

to style properly.

#2 @boonebgorges
13 years ago

  • Milestone Awaiting Review
  • Resolution → wontfix
  • Status new → closed

It looks like it's been this way since at least 1.2.

It would be nice to change it to be consistent. However, there are backward compatibility concerns - anyone who has intentionally styled .item-body and #item-body to be different will be frustrated to find that they have been changed. If we were going to change one of them, it'd have to be .item-body, which is only used in the context of group creation, and is thus less likely to have specific styles attached to it.

Because a new template pack is in the works, at which point bp-legacy templates will be legacy, I'm going to mark this ticket as wontfix. While the current setup is not ideal, it's pretty minor to work around it, and it'd be problematic to change it.

Thanks for the report!

Note: See TracTickets for help on using tickets.