Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #5130, comment 31


Ignore:
Timestamp:
03/28/2014 06:41:58 PM (12 years ago)
Author:
r-a-y

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5130, comment 31

    initial v1  
    11> To be honest, I'm still not clear on why we'd want this to be true, but I think your solution is fine for 2.0. Shouldn't we also be doing something in bp_blogs_sync_delete_post_comments_on_post_delete()? You have a $force_delete param but I can't see where it'd ever be used (you're hooked to 'bp_blogs_before_remove_post'.
    22
    3 Sorry, forgot to remove that part of the code from the patch.  Was experimenting with trash / untrash post status changes in `bp_blogs_transition_activity_status()` and how that handles comments and activity items related to comments.
     3Sorry, forgot to remove that part of the code from the patch.  Was experimenting with trash / untrash post status changes in `bp_blogs_catch_transition_post_status()` and how that handles comments and activity items related to comments.
    44
    55There are too many things required to get this working for 2.0-beta, so I decided to hold off.