Skip to:
Content

BuddyPress.org

Changes between Initial Version and Version 1 of Ticket #5130, comment 14


Ignore:
Timestamp:
03/17/2014 09:56:35 PM (12 years ago)
Author:
r-a-y

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #5130, comment 14

    initial v1  
    1515
    1616I've also had to change a few things:
    17 - Activity deletion callback now uses the 'bp_activity_delete_comment_pre' filter instead of the bp_activity_delete_comment' action because I need access to the activity comment children.  'bp_activity_delete_comment' is too late.
     17- Activity deletion callback now uses the `'bp_activity_delete_comment_pre'` filter instead of the bp_activity_delete_comment' action because I need access to the activity comment children.  `'bp_activity_delete_comment'` is too late.
    1818
    19 - Added utility function - bp_activity_recurse_comments_activity_ids() - to grab the activity IDs for an activity item
     19- Added utility function - `bp_activity_recurse_comments_activity_ids()` - to grab the activity comment IDs for an activity item
    2020
    21 - Added utility function - bp_blogs_remove_associated_blog_comments() - When an array of activity IDs are passed, this will try and find the blog comments that have an associated activity entry.  If there are matches, the blog comments are removed.
     21- Added utility function - `bp_blogs_remove_associated_blog_comments()` - When an array of activity IDs are passed, this will try and find the blog comments that have an associated activity entry.  If there are matches, the blog comments are removed.
    2222
    2323__2) Checking the blog's threaded comment depth setting__
    … …  
    3535My previous patch did not account for setting up the temporary globals when AJAX was used.
    3636
    37 This is now remedied in the new bp_blogs_setup_activity_loop_globals() and bp_blogs_setup_comment_loop_globals_on_ajax() functions.
     37This is now remedied in the new `bp_blogs_setup_activity_loop_globals()` and `bp_blogs_setup_comment_loop_globals_on_ajax()` functions.
     38
     39Perhaps we should look into caching the blog's threaded depth and the post's comment status options ourselves instead of using the singleton-stuffing method in this patch.
    3840
    3941Feedback welcome.