XProfile field edit screen UI update

[johnjamesjacoby]

The screen that appears when a site admin edits a profile field is out-of-date and ugly. It also still points to admin.php instead of users.php, causing the top-level-menu item to not be highlighted.

Imminent patch to bring the UI up to 2011 standard, and fix the incorrect links.

[johnjamesjacoby]

With patch applied

[boonebgorges]

The changes look pretty good to me at a glance, though I have not studied them in detail.

My preference, given where we are in the dev cycle, is to fix the users.php links (which strikes me as a legitimate bug, if not a regression in 1.8), and to push the markup/styling changes to 1.9. Though I see that you've made some adjustments in the js to account for the changed markup, I'm still wary of introducing non-essential changes this late in 1.8 that have the potential to break functionality.

[johnjamesjacoby]

In 7271:

In XProfile admin, replace admin.php links with users.php. Fixes regression from 1.6 when profile fields were moved out of Settings and into Users, causing the "Profile Fields" menu item to not appear currently selected. See #5094.

[johnjamesjacoby]

For 1.9, we should replace these hard-coded users.php links with bp_admin_url() and use add_query_arg().

[johnjamesjacoby]

In 7285:

Update XProfile field edit UI to match field group edit UI, for 1.9. See #5094.

[johnjamesjacoby]

Okay to close this. Future commits can reference this ticket, or be new issues.