Skip to:

Opened 11 years ago

Closed 11 years ago

Last modified 9 years ago

#5070 closed defect (bug) (fixed)

Ajax trouble in Private Messages with bulk delete action

Reported by: imath's profile imath Owned by: boonebgorges's profile boonebgorges
Milestone: 1.9 Priority: normal
Severity: normal Version: 1.8
Component: Messages Keywords: has-patch needs-testing


1/ In the inbox or in the sent box of private messages, if i bulk delete messages and once done if i click again, the ajax request will be sent with the same data as the deleted messages are only hidden and the checkbox remains checked. So once deleted, i suggest to uncheck the checkbox to avoid "double deletion"

2/ If i use the search form, once the result is displayed, using the selectbox to check the read/unread/all message will have no effect, same for the link to bulk delete the messages.

So i suggest the diff attached to solve the 2 bugs

Attachments (1)

5070.diff (5.9 KB) - added by imath 11 years ago.

Download all attachments as: .zip

Change History (7)

11 years ago

#1 @boonebgorges
11 years ago

  • Milestone changed from Awaiting Review to 1.9

#2 @boonebgorges
11 years ago

In 7411:

Improve JS for "Select" dropdown on messages screens

  • Use jQuery delegation, to ensure that items added to the DOM dynamically (as in an AJAX search query) are listening for clicks
  • Simplify logic

See #5070

Props imath

#3 @boonebgorges
11 years ago

In 7412:

Use delegation for bulk message actions.

This ensures that items added after AJAX actions are available for AJAX

See #5070

Props imath

#4 @boonebgorges
11 years ago

In 7413:

Uncheck message checkbox in interface after deletion

The deletion UX only hides the message - doesn't remove it from the DOM - so
we have to make sure it's unchecked, or it'll mess up the next request.

See #5070

Props imath

#5 @boonebgorges
11 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7415:

Remove element selectors from bp-default

Fixes #5070

Props imath

#6 @johnjamesjacoby
9 years ago

  • Version changed from 1.8-beta to 1.8
Note: See TracTickets for help on using tickets.