BP Legacy members settings templates markup issues

[hnla]

In bp-legacy/buddypress/members/single/

There is an issue with the /single/settings/ templates

home.php checks what template to include e.g settings.php it includes that template_part into a fully formed div#buddypress div#item-body set of elements.

In settings.php we check/switch to required template_part e.g general.php in that file and the others we are again stating #buddypress #itembody

We should really fix this as it doesn't look good, true this is a 'legacy' set of templates however they are out in the wild & in use and throwing markup warnings for duplicate ID's.

Deleting these additional elements from the inner template_parts ought to cause no issue as they are dups, testing on a local test site with fairly heavy custom styles around these elements caused no issues when I simply deleted the extraneous elements.

[henrywright]

If home.php loads settings.php and then settings.php loads general.php - doesn't that mean we'd have get_header( 'buddypress' ) load twice? e.g. once in home.php and once in general.php

In practice, i think home.php doesn't load settings.php. This means that general.php and notifications.php are loaded directly and settings.php isn't used.

[boonebgorges]

In practice, i think home.php doesn't load settings.php. This means that general.php and notifications.php are loaded directly and settings.php isn't used.

I'm pretty sure that's not right. I seem to remember that something like this happened in a recent version of bp-default, but bp-legacy in the master branch definitely loads home.php -> settings.php -> general.php, and so on.

Deleting these additional elements from the inner template_parts ought to cause no issue as they are dups

Yes. It appears that they are dupes, and they've just gone unnoticed since bp-legacy was first copied over in r6284.

[boonebgorges]

In 7199:

Remove <div id="buddypress"> wrappers from members/single/settings/ templates

The #buddypress div is added in the top-level template. It appears to have been
copied here by mistake when bp-legacy was first spawned from bp-default.

Fixes #5045

Props hnla

[hnla]

Re-opening with patch as need to also remove <div id="item-body"> from each template part and move 'role="main"' up to item-body in home.php

[hnla]

Patch removes item-body elements & moves 'role="main" to home.php

[boonebgorges]

In 7202:

Removes more redundant markup from bp-legacy members/single/settings/ templates

Fixes #5045 again

Props hnla

[henrywright]

I must have used that rogue recent version of bp-default. Both header.php and footer.php are included in notifications.php and general.php. I'll install a fresh copy.