Skip to:
Content

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#504 closed defect (bug) (fixed)

css is broken in group forums using IE7

Reported by: burtadsit Owned by: burtadsit
Milestone: Priority: major
Severity: Version:
Component: Keywords: css, RC-1, forums
Cc:

Description

css is completely broken by something when viewing bp group forums page in RC-1. Forums user brought it up. testbp.org is broke. My dev server and linux server too. Only visiting the forums page in IE7. Firefox and Safari are OK.

Nothing else seems affected. Just any group's forum pages.

Attachments (1)

closespan.patch (863 bytes) - added by burtadsit 5 years ago.
closespan fix

Download all attachments as: .zip

Change History (10)

comment:1 burtadsit5 years ago

This happens only on the forums index page. Drill down into a topic and all is fine. What's the diff? Looking.

comment:2 burtadsit5 years ago

While I was in there looking around I noticed this in /buddypress-member/groups/forum/topic.php line 68

<?php do_action( 'groups_forum_new_topic_after' ) ?>

Should be:

<?php do_action( 'groups_forum_new_reply_after' ) ?>

comment:3 burtadsit5 years ago

It's this:

<p><span class="activity"><?php echo sprintf( ( 'updated %s ago', 'buddypress' ), bp_the_topic_time_since_last_post( false ) ) ?><span></p>

It blows the rest of the page in IE. Testing a fix.

comment:4 burtadsit5 years ago

Same <p><span> sequence in the group home for active forum topics doesn't get trashed. Why?

comment:5 burtadsit5 years ago

Well the fix is: "Remove the <p><span> activity line". Works for me. It's late and I have to get up early. I'll revisit the IE nightmare tomorrow.

Or Andy could take pity on me and wave his magic IE knowledge wand and make it all go away by morning. One can always hope.

comment:6 burtadsit5 years ago

  • Owner set to burtadsit
  • Status changed from new to assigned

I assigned this to me because I started working on it. However, anybody who comes up with the solution is more than welcome to take the credit. I gotta run til later this afternoon.

comment:7 burtadsit5 years ago

Fixed. <span> needed to be closed. Three hours of ignoring the html validation error messages that the span tag wasn't closed finally led me to the inescapable and astounding conclusion that the span tag wasn't closed.

burtadsit5 years ago

closespan fix

comment:8 apeatling5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [1144]) Fixes #504, thanks to burtadsit for the patch.

comment:9 anonymous5 years ago

  • Milestone Forums 1.0 deleted

Milestone Forums 1.0 deleted

Note: See TracTickets for help on using tickets.