Skip to:

Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#5016 closed enhancement (wontfix)

Usage of <H*> selectors in theme compatibility templates

Reported by: ericlewis's profile ericlewis Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.7
Component: Templates Keywords:


Currently, <h*> elements are sprinkled throughout the theme compatibility templates of BuddyPress. However, this can lead to some unexpected output, as some themes may style specific <h*> elements as less-significant that are intended for item headers in BP templates (Group title on Twenty Eleven is notably significantly small and the weight is normal, giving the impression it's secondary information here).

Attachments (1)

Screen Shot 2013-05-24 at 2.10.27 AM.png (27.4 KB) - added by ericlewis 11 years ago.
Group header in twenty eleven, note small size of group title

Download all attachments as: .zip

Change History (4)

11 years ago

Group header in twenty eleven, note small size of group title

#1 @r-a-y
11 years ago

  • Keywords close 2nd-opinion added

This is a similar problem with themes in general.

Other than overriding the template part in question, there's not much we can do.

You can also use BP's special 'bp_replace_the_content' filter and replace the header tag with whatever you want.

See Beau Lebens' article for some inspiration:

But instead of the 'the_content' filter, use the one I state above. Untested, but it should work... hopefully!

Marking this ticket with the 2nd-opinion and close tags.

#2 @boonebgorges
11 years ago

  • Component changed from Template Pack to Theme
  • Keywords close 2nd-opinion removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I'm going to agree with r-a-y here. The problem is not us: We are using the semantically correct elements - at least, the semantically correct _HTML4_ elements, as our templates are minimally HTML5-ified. If themes do funny things do funny things with the way <h*> elements are styled (and I have actually seen themes that, eg, make <h3> bigger than <h2>, make <h4> smaller than the body text, etc), it's really a bug in that theme. The only ways we could work around it are (a) supply our own overriding styles, like #buddypress h3 { font-size: 1.2em; }, or (b) stop using header elements altogether. In the case of (a), we'd invariably clash with the native header styles of many themes, which defeats much of the purpose of theme compatibility. In case (b), we would still have to supply our own styles, *and* we'd be abandoning semantic web protocol.

Going to close as wontfix. Let's be evangelists to themers about this kind of stuff. Thanks for the report, ericlewis.

#3 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.