Skip to:
Content

Changes between Initial Version and Version 1 of Ticket #5012


Ignore:
Timestamp:
05/20/13 13:03:01 (5 years ago)
Author:
boonebgorges
Comment:

As you can see the top level URLs are broken

I see that in the markup you've pasted here, but I can't reproduce it on my current setup. What URL are you looking at when the nav menu is rendered? Is it a user page (example.com/members/foo/)?

groups-personal-li id is used twice

Confirmed. This does look like a bug. It looks like bp_nav_menu() has code that's supposed to prevent these sorts of duplicates, but I guess it's not working.

I really can't appreciate the difference between Memberships or Groups Top levels

I don't believe that Memberships is supposed to be a top level item - I think it's supposed to fall under Groups. I'm guessing that the nesting is breaking because of whatever's causing your top-level URLs to break.

the Messages Top level menu disappear, and except the submenus of the TopLevel? Activity the others doesn't have all their sub-menus.

Ditto. I'm guessing that something funny is happening because of where you are loading the menu, and this is the single cause of several of these issues. If you can provide more info about how you're using bp_nav_menu(), it'd be helpful.

found a 'solution' about missing submenu items, but I'm not sure if it's gonna be soo good.

You're right, it's not good :) It will allow anyone to edit anyone else's settings.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5012

    • Property Keywords reporter-feedback added
  • Ticket #5012 – Description

    initial v1  
    44 
    55Default menu for admin user: 
    6  
     6{{{ 
    77<div class="menu-bp-container"><ul id="menu-bp" class="menu"><li id="activity-personal-li"><a href="http://activity/">Activity</a> 
    88<ul class="sub-menu"> 
     
    5050</ul></div> 
    5151 
    52  
     52}}} 
    5353 
    5454Default menu for normal user: 
    55  
     55{{{ 
    5656<div class="menu-bp-container"><ul class="menu" id="menu-bp"><li id="activity-personal-li"><a href="http://activity/">Activity</a> 
    5757<ul class="sub-menu"> 
     
    7979</li> 
    8080</ul></div> 
    81  
     81}}} 
    8282 
    8383 
    8484Default menu inside a group created by normal user: http://example.com/wp2/groups/example_group/ 
    85  
     85{{{ 
    8686<div class="menu-bp-container"> 
    8787<ul class="menu" id="menu-bp"> 
     
    116116<li id="admin-personal-li"><a href="http://example.com/wp2/groups/example_group/admin/">Admin</a></li> 
    117117</ul></div> 
    118  
     118}}} 
    119119 
    120120As you can see the top level URLs are broken. Also groups-personal-li id is used twice, and I really can't appreciate the difference between Memberships or Groups Top levels, there are more problems as you can see that the Messages Top level menu disappear, and except the submenus of the TopLevel Activity the others doesn't have all their sub-menus.  
     
    125125I found a 'solution' about missing submenu items, but I'm not sure if it's gonna be soo good. Change the following function the menu works properly. Messages toplevel appear and load all submenu items as well. 
    126126 
    127  
     127{{{ 
    128128function bp_core_can_edit_settings() { 
    129129        if ( bp_is_my_profile() ) 
     
    136136        return false; 
    137137} 
     138}}}