Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#4997 closed enhancement (fixed)

Friend, mention, group counts etc should be run through number_format_i18n() before echoing

Reported by: boonebgorges Owned by: boonebgorges
Milestone: 1.8 Priority: normal
Severity: normal Version:
Component: Templates Keywords:
Cc:

Description

The counts that are displayed in the Mentions, Groups, Friends tabs and so on should be run through number_format_i18n() before being displayed in the template. (via nacin at https://buddypress.trac.wordpress.org/ticket/4916#comment:6)

Change History (3)

#1 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7177:

Run activity type counts through number_format_i18n() on activity index nav

Fixes #4997

#2 @boonebgorges
6 years ago

In 7520:

Improvements to i18n number formatting in activity count functions/templates

This changeset makes number formatting more consistent in the activity
templates of bp-legacy. The logic is as follows:

  • Move all number formatting out of the templates and into the relevant -template.php file.
  • Add number formatting to those _count() template functions that were missing it.
  • Clean up sprintf() swapping arguments to account for string vs int number formats

See #4997, #5228

Fixes #5231

#3 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.