Problematic custom activity slug

[henrywright]

define ( 'BP_ACTIVITY_SLUG', 'feed' );

http://buddypress.org/2009/05/customizable-slugs-in-buddypress/

Using "feed" as the activity slug results in members not being able to post an update to their activity stream.

Could using the slug "feed" be conflicting with some RSS functionality? Perhaps care should be taken when choosing to rename slugs? Renaming to the activity slug to words such as "wall" or "stream" seem to work fine.

[r-a-y]

I can duplicate this when theme compat is on, but not with bp-default. It's probably a conflict with WP's feed rewrite rules.

This might be alleviated when #4954 is implemented.

[slaFFik]

Seems we should check the slugs against prohibited/reserved strings, like feed.

[tw2113]

I concur with @slaFFik in that this should probably be a blacklisted value

[hnla]

Do we need to build a blacklist for slugs, can't recall of top of head whether we do reserve any strings where this sort of renaming is concerned, we did work up changes quite recently for activity stream dir as that wasn't re-nameable before, ought to look up that ticket.

[tw2113]

I know there's a similar functioning list found in bp_core_get_illegal_names() and bp-members-functions.php

[hnla]

So we'll need to run the dir titles via that get_illegal_names function before or after our default slugs are set, we essentially rely on WP page slugs.

Just dropping this commit ref in as it reminds me how we handle these slugs:
​https://buddypress.trac.wordpress.org/changeset/11080

This does strike me as something we ought to look into.

[imath]

Slug constants were deprecated in 12.0.0