Skip to:

Opened 11 years ago

Closed 5 months ago

#4996 closed defect (bug) (wontfix)

Problematic custom activity slug

Reported by: henrywright's profile henrywright Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.7
Component: Core Keywords:


define ( 'BP_ACTIVITY_SLUG', 'feed' );

Using "feed" as the activity slug results in members not being able to post an update to their activity stream.

Could using the slug "feed" be conflicting with some RSS functionality? Perhaps care should be taken when choosing to rename slugs? Renaming to the activity slug to words such as "wall" or "stream" seem to work fine.

Change History (7)

#1 @r-a-y
11 years ago

  • Keywords custom slugs removed
  • Milestone changed from Awaiting Review to Future Release

I can duplicate this when theme compat is on, but not with bp-default. It's probably a conflict with WP's feed rewrite rules.

This might be alleviated when #4954 is implemented.

#2 @slaFFik
7 years ago

Seems we should check the slugs against prohibited/reserved strings, like feed.

#3 @tw2113
7 years ago

I concur with @slaFFik in that this should probably be a blacklisted value

#4 @hnla
7 years ago

Do we need to build a blacklist for slugs, can't recall of top of head whether we do reserve any strings where this sort of renaming is concerned, we did work up changes quite recently for activity stream dir as that wasn't re-nameable before, ought to look up that ticket.

#5 @tw2113
7 years ago

I know there's a similar functioning list found in bp_core_get_illegal_names() and bp-members-functions.php

#6 @hnla
7 years ago

So we'll need to run the dir titles via that get_illegal_names function before or after our default slugs are set, we essentially rely on WP page slugs.

Just dropping this commit ref in as it reminds me how we handle these slugs:

This does strike me as something we ought to look into.

#7 @imath
5 months ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Slug constants were deprecated in 12.0.0

Note: See TracTickets for help on using tickets.