Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#4977 closed defect (bug) (fixed)

Group admin: Member features behave incorrectly because of lack of proper pagination support

Reported by: Gargoyle297 Owned by: boonebgorges
Milestone: 1.8 Priority: normal
Severity: normal Version: 1.7
Component: Groups Keywords: needs-patch
Cc:

Description

WP: 3.4.1 - Single site
BP: 1.7 - Default theme
Other Plugins: membership 3.4.4.1, Events Manager 5.3.5, Contact Form plugin 3.41, Lazyest gallery 1.1.20, Widget Logic 0.56, WP Survey And Quiz Tool 2.13.1
I’m near to make the new communitie’s site start and i’m registering all my wp imported users to the public ‘triari’ buddypress group.
Using the admin function ‘GROUP’ in the admin dashboard i’m adding users.

  • First one is assigned as administrator
  • Second one as the moderator

and then all the others as members.
When i save the 19th member (it means ‘id in the group’ = 21) the administrator member disappear from the list and the system tells me I cannot drop all the admins !!!
I can’t go any further but the front-end group dashboard presents me the correct situation: The administrator is still there and with the correct credentials.
Coming back to the back-end group, promoting one of the visible member as admin and then inserting the 20th member (id=22) the Moderator (id=2) disappears too!
I think this is could be a Group-Dashboard bug
Thanks

Change History (7)

#1 @boonebgorges
7 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 1.8
  • Summary changed from Back-end group admin issue to Group admin: Member features behave incorrectly because of lack of proper pagination support

Thanks very much for the detailed bug report.

I believe you are correct that it is a bug. There were some limitations to the way that the group-member queries work that caused problems with the first round implementation of the group Dashboard pages in BP 1.7.

The changes proposed in #4482 are a prerequisite to fixing this sort of issue.

#2 @boonebgorges
7 years ago

Marked #5000 as a duplicate.

#3 @boonebgorges
6 years ago

In 7141:

Introduces BP_Group_Member_Query and refactors bp_group_has_members() to use it

BP_Group_Member_Query extends BP_User_Query, which has a number of notable
benefits:

  • Group member queries no longer JOIN against global user tables
  • Less code duplication, since general logic like 'exclude' is handled by BP_User_Query
  • Future access to the additional parameters of BP_User_Query, such as 'type'

Using the new BP_Group_Member_Query, this changeset also changes the way that
group member queries filter by group roles (member, mod, admin). The new
group_role parameter in the bp_group_has_members() stack accepts an array of
group roles. The legacy argument 'exclude_admins_mods' is still accepted, and
translates to 'group_role' => array( 'member' ) when true. These group_role
enhancements will allow for future enhancements in the Groups Admin section of
the Dashboard, and other places where it might be useful to query for the
members of a group matching a specific role. See #4977.

Fixes #4482

Props trishasalas for early patches and feedback. Props johnjamesjacoby for
review.

#4 @boonebgorges
6 years ago

In 7145:

Deprecate exclude_banned arg of bp_group_has_members() in favor of 'banned' role

This changeset introduces support for the 'banned' group_role filter in
BP_Group_Member_Query. This takes the place of the exclude_banned parameter.
Backward compatibility for exclude_banned is added in
groups_get_group_members().

See #4977

#5 @boonebgorges
6 years ago

In 7158:

Introduces pagination for member types on Group Admin > Manage Members

When the Group Admin Dashboard panels were introduced in BuddyPress 1.7, the
Manage Member section was missing pagination. As a result, managing membership
in a group with more than 20 members could result in odd bugs, ranging from not
being able to see/modify all the members in your group, to receiving erroneous
error messages when attempting to modify user roles. Adding pagination for each
member type ensures that all group members can be viewed and modified by the
group administrator.

See #4977

#6 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7159:

Add "Are you sure you want to leave this page?" js for unsaved changes on Group Admin

Fixes #4977

#7 @boonebgorges
6 years ago

I've made improvements to the Group Admin panels that should address the issues raised in this ticket. Thanks again for the report.

Note: See TracTickets for help on using tickets.