Add filters to bp_directory_groups_search_form() and bp_directory_members_search_form()

[megainfo]

I suggest adding some filters for the html code returned by

bp_directory_groups_search_form() and bp_directory_members_search_form()

[boonebgorges]

I think we can do this.

[dimensionmedia]

Looked simple enough, but let me your know feedback. First time submitting a patch, but don't be gentle.

[boonebgorges]

Technique looks fine in bp_directory_groups_search_form(), but it looks like the implementation in bp_group_search_form() is incomplete. The ?> delimiter needs to be moved, the nonce field needs to be included in the string, and the string needs to be echoed and run through apply_filters().

[dimensionmedia]

Updates to bp-members-template and bp-groups-template

[dimensionmedia]

hhmm... not sure what happened. Ticket wasn't even concerning bp_group_search_form(), but nevertheless I applied the same technique to that function as well.

Please note that 4972.2.diff attachement contains the latest code adjustments.

[boonebgorges]

In 7328:

Adds filters to search form HTML functions

Filters introduced in bp_directory_members_search_form(),
bp_directory_groups_search_form(), and bp_group_search_form() allow theme
and plugin authors more flexibility with core-generated search form HTML.

Fixes #4974

Props dimensionmedia

[boonebgorges]

Looks good. Thanks!

[hnla]

A few points and a patch correction.

Patch 4974.3 corrects escaped value attr string; needs to be passed through not echoed: () rather than _e().

1/ Why have we only highlighted two of the dir search forms for this re-factoring, is there a reason the legacy forum search and blogs search weren't changed?.

2/ Where is bp_group_search_form() actually used? I can find no reference to it other than the groups template core file

[hnla]

Corrects value attr in inputs

[boonebgorges]

In 7339:

Use the correct translation function when building search form HTML

This corrects incorrect use of _e() in r7328

See #4974

Props hnla

[boonebgorges]

Good catch on _e(), hnla. Thanks for the patch.

Your questions:

1 - We've only changed it here because this is all the original patch did. It would be nice to extend the same treatment to all search form html generating functions. We just need a patch.

2 - I don't think it is used anywhere by BP, nor has it been for a number of years. We have to keep it in there for backward compatibility, as some themes/installations may be using it.

[hnla]

1 - We've only changed it here because this is all the original patch did. It would be nice to extend the same treatment to all search form html generating functions. We just need a patch.

The other two will need patching as it could prove awkward for developers wanting to re-factor all of them.

2 - I don't think it is used anywhere by BP, nor has it been for a number of years. We have to keep it in there for backward compatibility, as some themes/installations may be using it.

Oh my favourite phrase 'backwards compatibility' - I can't find theme use of the function checking back to 1.2 locally, although perhaps not strictly 'deprecated' can this not be pulled out of the file and added to one of those /bp-core/deprecated/ files, less clutter in current core files?

[dimensionmedia]

Added filters for blog and forum search forms.

[hnla]

@dimensionmedia
Good stuff, glad I spotted the ticket update before doing so myself, however why did you re-patch the whole lot?

A final thing to consider before the patch/ticket closed: The labels are empty, they ought not to be, text ought to be added hidden if necessary with a assistive-text class - as found iirc in one of the WP default stylesheets of course this may upset themes that have overridden or copied all BP styles.

[boonebgorges]

dimensionmedia - Thanks for the new patch. Would you mind regenerating it against the latest trunk? The one you have here won't apply cleanly, because some of the changes have already been committed.

hnla - The label stuff is separate from the main issue discussed in this ticket. Perhaps you could open a new one and we could hash it out there.

[dimensionmedia]

Updated bp_directory_forums_search_form() and bp_directory_blogs_search_form() against latest trunk.

[boonebgorges]

In 7345:

Adds filters to Blogs and Forums search form markup

Fixes #4974

Props dimensionmedia