Using Jquery .live() insteed .click()

[megainfo]

I suggest using jquery .live() function instead .click() in all javascript events.

.click() is not applied if the content is recovered from ajax response ( for example, if you click 'add friend' then ajax answer is an html input button 'Cancel Friendship Reques' , the .click() event is not applied to this new button).

[boonebgorges]

.live() is deprecated. We should be using .on() with proper event delegation.

If you find specific places in our JS where we're using .click() and need the delegation, please post them here.

[megainfo]

In file bp-legacy/js/buddypress.js

lines : 989, 1013 , 1058

[megainfo]

Update global.js (replace all .click with .on( 'click', function(event) { )

[megainfo]

Update buddypress.js (replace all .click with .on( 'click', function(event) { )

[boonebgorges]

In 6972:

Use event delegation for directory buttons in bp-legacy

This ports r6919 to bp-legacy

See #4931, #4969

[boonebgorges]

In 6973:

Use event delegation for directory buttons in bp-legacy

This ports r6919 to bp-legacy

See #4931, #4969

[boonebgorges]

In 6974:

Use event delegation to disable .pending buttons in bp-legacy

See #4969

Props megainfo

[boonebgorges]

So far as I can tell, the other instances you mention (1013, 1058) are for buttons/links that are never added by AJAX to the page, at least not in the context of bp-legacy. I don't think we need to go to the trouble of doing true event delegation for those items, as it would require changing some of the logic of the JS. For this reason, I'm going to mark this ticket as fixed. If you find more instances where we *need* to use delegation, please feel free to reopen this ticket with details, or open a new ticket. Thanks!