Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 5 years ago

#4934 closed enhancement (fixed)

New action or new placement for action 'bp_before_directory_members_content'

Reported by: dontdream Owned by: boonebgorges
Milestone: 1.8 Priority: low
Severity: minor Version: 1.7
Component: Templates Keywords: has-patch
Cc:

Description

In bp-themes/bp-default/members/index.php the action 'bp_before_directory_members_content' is placed between the title "Members Directory" and the members search box, that's floated right and so it's on the same horizontal line of the title.

Probably a better placement would be after the members search box and before the navigation bar.

If moving an existing action is undesirable, I suggest adding a new one in the place requested. Typical usage would be the insertion of a search form, or image, or custom text before the navigation bar.

Attachments (3)

index.php (3.0 KB) - added by dontdream 9 years ago.
edited copy of index.php
index.php.patch (587 bytes) - added by dontdream 9 years ago.
new-action.patch (1.2 KB) - added by dontdream 9 years ago.

Download all attachments as: .zip

Change History (12)

@dontdream
9 years ago

edited copy of index.php

#1 @dontdream
9 years ago

  • Keywords has-patch added

@dontdream
9 years ago

#2 @dontdream
9 years ago

I realized that the previous patch was incomplete, because the action is needed both in bp-themes/bp-default and in bp-templates/bp-legacy. Added the new patch version.

#3 @dontdream
9 years ago

  • Summary changed from Better placement for action 'bp_before_directory_members_content' to New action or new placement for action 'bp_before_directory_members_content'

#4 @boonebgorges
9 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to 1.8
  • Priority changed from normal to low
  • Severity changed from normal to minor

Yes, we'll have to add a new action, as moving the existing one will break current implementations.

#5 @dontdream
9 years ago

Hi Boone,

I forgot to say that my proposed patch adds a new action, and doesn't touch the existing one. So I'm adding back the keyword 'has-patch' for your consideration.

Thanks,
Andrea

#6 @dontdream
9 years ago

  • Keywords has-patch added; needs-patch removed

#7 @boonebgorges
9 years ago

Cool, this'll work. Thanks, dontdream!

#8 @boonebgorges
9 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7118:

Introduces bp_before_directory_members_tabs action hook

This action provides a place for plugins and themes to insert content after
the member directory search box is rendered.

Fixes #4934

Props dontdream

#9 @DJPaul
5 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.