Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#4932 closed defect (bug) (fixed)

In BP Template / BP Legacy, html trouble in activity entry.php when user !logged in

Reported by: imath Owned by:
Milestone: 1.7.1 Priority: normal
Severity: minor Version: 1.7
Component: Activity Keywords: has-patch
Cc:

Description

In bp-template/bp-legacy/buddypress/activity/entry.php, a div is opened outside a if ( is_user_logged_in() ) statement and is closed inside the if ( is_user_logged_in() ) statement.

I suggest the diff attached.

Attachments (1)

4932.diff (423 bytes) - added by imath 9 years ago.

Download all attachments as: .zip

Change History (7)

@imath
9 years ago

#1 follow-up: @boonebgorges
9 years ago

Thanks, imath. Someone should check whether the same thing exists in bp-default.

#2 in reply to: ↑ 1 @imath
9 years ago

Replying to boonebgorges:

Someone should check whether the same thing exists in bp-default.

You're welcome ;) I've checked yesterday and i think it's ok in bp-default.

#3 @boonebgorges
9 years ago

  • Milestone changed from Awaiting Review to 1.7.1

OK, I've confirmed that the bug was introduced in r6796, and only affects the bp-legacy templates. Thanks again, imath!

#4 @boonebgorges
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6914]) Fix broken markup nesting in bp-legacy activity/entry.php

A logic error was causing invalid markup for non-logged-in users

Fixes #4932

Props imath

#5 @boonebgorges
9 years ago

(In [6915]) Fix broken markup nesting in bp-legacy activity/entry.php

A logic error was causing invalid markup for non-logged-in users

Fixes #4932

Props imath

#6 @hnla
8 years ago

Footnote to this issue:
While much goes into commenting php, laudably, there is a convention in commenting markup that ought to be followed (more) as it's reason is to help avoid these issues and highlight what one is scanning down through. Where a closing tag is far removed from it's opening one and where, thus, it gets difficult to know or remember to what it references one tends to do:
</div><!-- /.activity-meta -->

This just helps to keep track on correct opening closing pairs and in markup files of more complex structure becomes essential to retaining ones sanity when trying to debug.

Note: See TracTickets for help on using tickets.