In BP Template / BP Legacy, html trouble in activity entry.php when user !logged in

[imath]

In bp-template/bp-legacy/buddypress/activity/entry.php, a div is opened outside a if ( is_user_logged_in() ) statement and is closed inside the if ( is_user_logged_in() ) statement.

I suggest the diff attached.

[boonebgorges]

Thanks, imath. Someone should check whether the same thing exists in bp-default.

[imath]

Replying to boonebgorges:

Someone should check whether the same thing exists in bp-default.

You're welcome ;) I've checked yesterday and i think it's ok in bp-default.

[boonebgorges]

OK, I've confirmed that the bug was introduced in r6796, and only affects the bp-legacy templates. Thanks again, imath!

[boonebgorges]

(In [6914]) Fix broken markup nesting in bp-legacy activity/entry.php

A logic error was causing invalid markup for non-logged-in users

Fixes #4932

Props imath

[boonebgorges]

(In [6915]) Fix broken markup nesting in bp-legacy activity/entry.php

A logic error was causing invalid markup for non-logged-in users

Fixes #4932

Props imath

[hnla]

Footnote to this issue:
While much goes into commenting php, laudably, there is a convention in commenting markup that ought to be followed (more) as it's reason is to help avoid these issues and highlight what one is scanning down through. Where a closing tag is far removed from it's opening one and where, thus, it gets difficult to know or remember to what it references one tends to do:
</div><!-- /.activity-meta -->

This just helps to keep track on correct opening closing pairs and in markup files of more complex structure becomes essential to retaining ones sanity when trying to debug.