Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4919 closed defect (bug) (fixed)

Groups Admin: Cannot change Public Groups to Hidden

Reported by: mercime's profile mercime Owned by:
Milestone: 1.7 Priority: normal
Severity: normal Version: 1.7
Component: Administration Keywords:
Cc:

Description

"Committee" Group was created from front end as a Public Group.

I wanted to change the group from Public to Hidden from wp-admin dashboard menu Groups.

  • Click on "edit" link under "Committee".
  • In Edit Group panel's Settings box, I change from Public to Hidden
  • Click "Save Changes".
  • It doesn't work, i.e., after clicking Save Changes, the button goes back to Public and going to groups directory, the Group is still labeled as Public and visible to logged out visitor.

To double-check if I can change Group visibility in front end,

  • I go to the Groups Directory end and click on "Committee" Group link.
  • Click on Admin link, click on Settings subnav link.
  • choose "This is a hidden Group" and click on Save Changes button. - The changes take effect - for logged in admin, it shows Hidden group status and for logged out user, the line for the Group and meta does not show up anymore as expected.

Change History (11)

#1 @boonebgorges
12 years ago

  • Keywords reporter-feedback added

Hm, it's working on my installations. What's your WP version? Which rev of BP? Multisite or no?

#2 @chouf1
12 years ago

Hi Boone,

sorry to say, but i have the same problem as @mercime.

  • unable to activate "hidden" from dashboard.
  • works ok from frontend.

BP 1.7RC1 rev. 6846 / WP 3.5.1 theme BootstrapWP ( http://bootstrapwp.rachelbaker.me/ )

Last edited 12 years ago by chouf1 (previous) (diff)

#3 @boonebgorges
12 years ago

Thanks, chouf1. Is it only "hidden" that is causing the problem? Can you change the group status to "private"? Does the problem persist when you use a different theme?

#4 @chouf1
12 years ago

i just updated to the latest 6894 trunk and same problem comes up.

i tried to change the group title and modified from hidden to private: changes are not taken on registering.

#5 @chouf1
12 years ago

unsuccessfully testing with bp-default and Salutations.
Unable to modify group title and status from dashboard.

#6 @mercime
12 years ago

  • Keywords reporter-feedback removed

Hi Boone. Sorry I forgot to add the info about the installation.

Re: issue above -> WP single. BP RC 1 on WP 3.6 RC 1 with bbPress RC 1.

  • While there is an admin notice "The group has been updated successfully." the radio button keeps going back to Public. This is the same for when I try to change to "Private" group.

Note: Checked on other site this morning -> WP single. BP latest trunk (edit- trunk 6893) on WP 3.6 RC 1 with bbPress latest trunk.

  • Successful change in the backend for groups tested to any privacy setting.
Last edited 12 years ago by mercime (previous) (diff)

#7 @chouf1
12 years ago

Sorry, i also forget to mentionned that i'm on a multisite install.

#8 @boonebgorges
12 years ago

  • Milestone changed from Awaiting Review to 1.7

Thanks for the additional details, mercime and chouf1.

I've pretty much found the bug. It's a BP bug, but it's only showing up if you are running bbPress trunk. We're not correctly deleting single group caches when group details are saved. Not sure how this didn't come up before, but since it's a straightforward fix I'm going to just do it.

#9 @boonebgorges
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6896]) Pass the 'bp' group to wp_cache_delete() in bp_groups_delete_group_cache()

The absence of this group parameter meant that the cache deletion was never
actually working, causing problems with persistent caching as well as plugins
that cause group details to be saved multiple times on a pageload (such as
bbPress)

Fixes #4919

#10 @chouf1
12 years ago

Super, ça marche ! Thank you for this quick fix, Boone !

#11 @boonebgorges
12 years ago

Merci à toi pour le reportage!

Note: See TracTickets for help on using tickets.