Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 4 years ago

Last modified 3 years ago

#4904 closed defect (bug) (no action required)

Theme compat: CSS problems with P2 theme

Reported by: DJPaul Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.7
Component: Templates Keywords: has-patch dev-feedback
Cc:

Description

From #4900:

https://buddypress.trac.wordpress.org/attachment/ticket/4900/p2-not-compat.jpg

* Members page title is repeated
* Action buttons are cut off
* Clear left needed for li elements in member list

Attachments (1)

4904.01.patch (730 bytes) - added by DJPaul 7 years ago.

Download all attachments as: .zip

Change History (8)

#1 @DJPaul
7 years ago

  • Keywords has-patch dev-feedback added

We can't do anything about the page title being duplicated; that's just how P2 is.

I couldn't figure out a safe fix for the action buttons (I've only seen that issue on P2, too).

But 4904.01.patch fixes the not-cleared rows on the Members list. It took a bit of puzzling, but this problem actually does occur on other themes and the other directory lists, but the problem was hidden because the height of the rows was sufficient to force the following content to render beneath it.

@DJPaul
7 years ago

#2 @mercime
7 years ago

Fixed page title duplication by using buddypress.php wrapper which moved location of page title to within loop. Same wrapper fixed action buttons.

Compare buddypress.php posted in https://buddypress.trac.wordpress.org/ticket/4900 with P2 page.php

#3 @johnjamesjacoby
7 years ago

  • Keywords early added
  • Milestone changed from 1.7 to 1.8
  • Version set to 1.7

Going to punt to 1.8, and we can pull into 1.7.early if we want.

#4 @boonebgorges
7 years ago

  • Keywords early removed

#5 @boonebgorges
6 years ago

  • Milestone changed from 1.8 to Future Release

#6 @DJPaul
4 years ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

Going to close my own ticket as don't care about P2, and it's probably works better now than it did two years ago, anyway.

#7 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.