Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

#4901 closed defect (bug) (fixed)

Groups Admin UI : subsubsub links and querystring

Reported by: imath Owned by: boonebgorges
Milestone: 1.8 Priority: normal
Severity: normal Version: 1.7
Component: Administration Keywords: has-patch needs-testing early
Cc:

Description

Hi,

I think that in the new Group Admin UI, the $url_base that is used by the links of the subsubsub section should have more args removed.

For instance, as the 's' arg is not removed, then clicking on the link "All" always displayed the latest search.
Another example : if you are on page 2 of all groups and then you want to see the one and only group that is private from the "Private (1)" link of the subsubsub section, then you are not able to view it as the 'paged' arg is not removed and there are not enough private groups to populate a second page.

So i suggest the diff attached to this ticket. In it, I also removed some other args such as '_wpnonce', '_wp_http_referer', 'action', 'action2'.

Attachments (2)

4901.diff (1.1 KB) - added by imath 7 years ago.
4901.02.diff (2.7 KB) - added by boonebgorges 7 years ago.

Download all attachments as: .zip

Change History (5)

@imath
7 years ago

#1 @DJPaul
7 years ago

  • Component changed from Core to Administration
  • Keywords early added
  • Milestone changed from Awaiting Review to 1.8

Similar would need to be done for the Activity admin screen; same problem there. We should do the same as whatever WP does for the Posts screen.

#2 @boonebgorges
7 years ago

Given that we're pretty much removing everything, it makes much more sense to me that we should be rebuilding the URL rather than trying to come up with an exhaustive list of items to remove. See 4901.02.diff.

I'm posting here before committing, because as written, my patch would wipe out the 'activity_type' filter when switching between views. That's a change from current behavior. I don't know if it's better or worse, and was hoping to get feedback.

@boonebgorges
7 years ago

#3 @boonebgorges
7 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7175:

When building get_views() links on Groups and Activity admin, build URL base from scratch

Previously, we were taking the current URL and removing query args by name.
Invariably, some query args would be forgotten about, leading to unpredictable
results. By building the base URL from scratch, we avoid any danglers.

Fixes #4901

Note: See TracTickets for help on using tickets.