Theme compat: notices with P2 theme

[mercime]

BuddyPress RC 1 - error:

Notice: Trying to get property of non-object in /xxx/xxx/xxx/xxx/wp-includes/capabilities.php on line 1075
Notice: Trying to get property of non-object in /xxx/xxx/xxx/xxx/wp-includes/capabilities.php on line 1076
Notice: Trying to get property of non-object in /xxx/xxx/xxx/xxx/wp-includes/capabilities.php on line 1076
Notice: Trying to get property of non-object in /xxx/xxx/xxx/xxx/wp-includes/capabilities.php on line 1079
Notice: Trying to get property of non-object in /xxx/xxx/xxx/xxx/wp-includes/capabilities.php on line 1079

[mercime]

P2 is a special theme which some are already using in BuddyPress sites. Per attached image, following issues show up with theme compat:

1. Members page title is repeated

2. Author post area shows up with warning in the background

3. Action buttons are cut off

4. Clear left needed for li elements in member list

5. Avatars in Groups and Members Widget are much smaller compared to the default avatars in other BP widgets

6. Item meta .activity in Groups and Members Widget area are not aligned under names of Group or Members

7. Who's Online widget - duplication of mercime avatar after recently posting status update

Some of the issues above could be addressed

• #1, #2, #3: special case, providing custom buddypress.php file to be uploaded by user in theme's folder
• #4, #5, #6: needs patch for bp-legacy's css
• #7: needs patch - the issue shows up in twenty twelve theme as well

[DJPaul]

line 1079, wp-includes/capabilities.php - get_post_type_object( 'bp_members' ) === null

caused by current_user_can('edit_posts') at ​http://themes.trac.wordpress.org/browser/p2/1.4.2/entry.php#L51

[DJPaul]

Separate tickets would have been easier to track these issues -- going to keep this one for the Notices, and will a new ticket for all styling, and another for the widget

[DJPaul]

For widget avatars and "Item meta .activity", see #4869

[DJPaul]

Other CSS issues in #4904

[mercime]

Separate tickets would have been easier to track these issues -- going to keep this one for the Notices

Thanks. Will point this ticket to P2 users for 1.7 theme compat.

Other issue found:

• 8. Flashing updates. Shows up in default theme compat or with buddypress.php uploaded in P2 theme folder in server. ​https://buddypress.trac.wordpress.org/attachment/ticket/4900/p2-flashing-updates.jpg

I'm attaching ​https://buddypress.trac.wordpress.org/attachment/ticket/4900/buddypress.php file which users can upload to P2 theme folder in server. Fixes #1, #2, and #3. Upload of this file shows some more issues ​https://buddypress.trac.wordpress.org/attachment/ticket/4900/p2-vertspace-imgavatar.jpg :

• 9. very long vertical space between status/item header and activity-list/members-list/groups-list,etc.
• 10. activity item img.avatar is not displayed inline

#9 and #10 could be addressed via CSS fixes specific to the P2 theme's stylesheet as these issues do not show up in other WP themes I tested

#buddypress ul.item-list {
    clear: none !important;
}  
#buddypress .activity-list .activity-content .activity-header img.avatar {
    display: inline;
} 

[mercime]

flashing updates high number when only made status update

[mercime]

buddypress.php for P2 theme

[mercime]

with buddypress.php long vertical space and image avatar issue

[johnjamesjacoby]

Not extremely concerned with these. P2 is getting more attention internally at Automattic, and we'll see an influx of themes where BuddyPress doesn't work perfectly after 1.7 ships.

[mercime]

#7 above is not valid. Tester used my avatar and username plus _one.

[mercime]

Just for the record, no one is reporting issues with P2 theme in BP forums nor are there any requesting assistance for theme compat with P2 theme.

[mercime]

In that regard, I suggest we close this ticket already. Anyone who has an issue in the future can reopen.

[boonebgorges]

Sounds good, mercime. Thanks for being on top of this one!